From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15300 invoked by alias); 8 Feb 2007 13:57:02 -0000 Received: (qmail 15286 invoked by uid 22791); 8 Feb 2007 13:57:01 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 08 Feb 2007 13:56:53 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HF9lb-0001Tg-BM; Thu, 08 Feb 2007 08:56:51 -0500 Date: Thu, 08 Feb 2007 13:57:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: XML XInclude support Message-ID: <20070208135651.GA5269@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20070129213229.GA17422@nevyn.them.org> <20070206124910.GA31162@nevyn.them.org> <20070207183656.GA14189@nevyn.them.org> <20070207184458.GA15589@nevyn.them.org> <20070207224910.GA26062@nevyn.them.org> <200702081306.l18D62PH028549@brahms.sibelius.xs4all.nl> <20070208131355.GA3489@nevyn.them.org> <200702081345.l18DjWo9029777@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200702081345.l18DjWo9029777@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00071.txt.bz2 On Thu, Feb 08, 2007 at 02:45:32PM +0100, Mark Kettenis wrote: > > Could you try replacing that line with this, to avoid the % being > > interpreted as a format specifier? > > > > printf "'\''%c'\'', ", c > > That seems to work, Thanks! Oof - glad I checked; that's wrong. I've committed this instead, which should still work for you, but not leave binary gunk in the file. %c interprets 'a' as a character but '0' as an ASCII code. Ever feel like I accomplish nothing except breaking your builds? :-) -- Daniel Jacobowitz CodeSourcery 2007-02-08 Daniel Jacobowitz * features/feature_to_c.sh: Use %s to avoid problems with nawk. Index: gdb/features/feature_to_c.sh =================================================================== RCS file: /cvs/src/src/gdb/features/feature_to_c.sh,v retrieving revision 1.2 diff -u -p -r1.2 feature_to_c.sh --- gdb/features/feature_to_c.sh 7 Feb 2007 22:48:06 -0000 1.2 +++ gdb/features/feature_to_c.sh 8 Feb 2007 13:55:08 -0000 @@ -51,7 +51,7 @@ for input; do } else if (c == "\\") { printf "'\''\\\\'\'', " } else if (_ord_[c] >= 32 && _ord_[c] < 127) { - printf "'\''" c "'\'', " + printf "'\''%s'\'', ", c } else { printf "'\''\\%03o'\'', ", _ord_[c] }