From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: gdb-patches@sourceware.org
Subject: Re: Testsuite failures in gdb.base/callfuncs.exp
Date: Thu, 01 Feb 2007 22:53:00 -0000 [thread overview]
Message-ID: <200702012253.l11MrYDH006566@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20070131151001.GA25714@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 31 Jan 2007 10:10:01 -0500)
> Date: Wed, 31 Jan 2007 10:10:01 -0500
> From: Daniel Jacobowitz <drow@false.org>
>
> On Wed, Jan 31, 2007 at 03:56:57PM +0100, Andreas Schwab wrote:
> > Daniel Jacobowitz <drow@false.org> writes:
> >
> > > On Wed, Jan 31, 2007 at 02:56:16PM +0100, Andreas Schwab wrote:
> > >> bsp can only be modified by writing to bspstore, which is what the kernel
> > >> does behind our back. gdb itself never writes to bspstore. Thus the
> > >> value of bspstore does not really matter.
> > >
> > > Could we restore it if we tried?
> >
> > Why would we want to?
>
> I don't know. To leave the inferior's state as untouched as possible
> after an artificial function call.
>
> If you're convinced that's not useful, patch is OK.
No I think there actually is a problem. Either the bspstore matters
or it doesn't. If it doesn't, GDB should just not include it in the
list of registers it displays. If it does matter, the test is showing
a genuine bug.
Mark
next prev parent reply other threads:[~2007-02-01 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 12:33 Andreas Schwab
2007-01-31 12:49 ` Daniel Jacobowitz
2007-01-31 13:56 ` Andreas Schwab
2007-01-31 14:15 ` Daniel Jacobowitz
2007-01-31 14:57 ` Andreas Schwab
2007-01-31 15:10 ` Daniel Jacobowitz
2007-01-31 15:35 ` Andreas Schwab
2007-01-31 15:40 ` Daniel Jacobowitz
2007-02-01 22:53 ` Mark Kettenis [this message]
2007-02-01 23:29 ` Andreas Schwab
2007-02-08 17:03 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702012253.l11MrYDH006566@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox