From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [mi] kill release_value calls
Date: Wed, 24 Jan 2007 19:40:00 -0000 [thread overview]
Message-ID: <20070124194009.GA23437@nevyn.them.org> (raw)
In-Reply-To: <200701242233.30910.ghost@cs.msu.su>
On Wed, Jan 24, 2007 at 10:33:30PM +0300, Vladimir Prus wrote:
>
> This patch removes all calls to release_value in varobj.c, except
> for one. We only need to call release_value when we're storing
> a value for indefinite future use, and install_new_value is the
> only such place. The extra release_value calls either
> are time-consuming no-ops, or lead to memory leaks,
> depending on the value type.
>
> OK?
OK. My apologies to Nick - I'd told him this was wrong, but I was
mistaken.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-24 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-24 19:33 Vladimir Prus
2007-01-24 19:40 ` Daniel Jacobowitz [this message]
2007-01-24 19:55 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070124194009.GA23437@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox