From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25261 invoked by alias); 24 Jan 2007 19:40:23 -0000 Received: (qmail 25242 invoked by uid 22791); 24 Jan 2007 19:40:21 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 24 Jan 2007 19:40:13 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H9nyb-00068H-SR; Wed, 24 Jan 2007 14:40:10 -0500 Date: Wed, 24 Jan 2007 19:40:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [mi] kill release_value calls Message-ID: <20070124194009.GA23437@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200701242233.30910.ghost@cs.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701242233.30910.ghost@cs.msu.su> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00504.txt.bz2 On Wed, Jan 24, 2007 at 10:33:30PM +0300, Vladimir Prus wrote: > > This patch removes all calls to release_value in varobj.c, except > for one. We only need to call release_value when we're storing > a value for indefinite future use, and install_new_value is the > only such place. The extra release_value calls either > are time-consuming no-ops, or lead to memory leaks, > depending on the value type. > > OK? OK. My apologies to Nick - I'd told him this was wrong, but I was mistaken. -- Daniel Jacobowitz CodeSourcery