From: Daniel Jacobowitz <drow@false.org>
To: Denis PILAT <denis.pilat@st.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] thread apply commands change selected frame
Date: Sun, 21 Jan 2007 17:33:00 -0000 [thread overview]
Message-ID: <20070121173341.GG12463@nevyn.them.org> (raw)
In-Reply-To: <45A61E73.8030400@st.com>
On Thu, Jan 11, 2007 at 12:24:35PM +0100, Denis PILAT wrote:
> Hi everyone,
>
> I noticed a potential problem in thread.c: the "thread apply" commands
> change the selected frame, I think it should not.
> If you are doing
> (gdb) up
> (gdb) thread apply all print 1
> (gdb) down
> then the frame selected before the up is not being restored by the down,
> we have an error message instead.
Yeah, that's a strange behavior.
> I need your opinion before going ahead in this patch.
It looks right to me. With a ChangeLog entry and testsuite results
from some target with threads, it would be OK to commit.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-21 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 11:24 Denis PILAT
2007-01-21 17:33 ` Daniel Jacobowitz [this message]
2007-01-24 10:42 ` Denis PILAT
2007-01-31 8:58 ` Denis PILAT
2007-01-31 14:54 ` Daniel Jacobowitz
2007-01-31 19:30 ` Denis PILAT
2007-01-31 19:33 ` Daniel Jacobowitz
2007-02-01 9:49 ` [RFA] " Denis PILAT
2007-02-01 14:33 ` Daniel Jacobowitz
2007-02-02 12:40 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070121173341.GG12463@nevyn.them.org \
--to=drow@false.org \
--cc=denis.pilat@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox