From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18371 invoked by alias); 21 Jan 2007 17:33:55 -0000 Received: (qmail 18360 invoked by uid 22791); 21 Jan 2007 17:33:54 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 21 Jan 2007 17:33:47 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H8gZZ-0003iY-Li; Sun, 21 Jan 2007 12:33:41 -0500 Date: Sun, 21 Jan 2007 17:33:00 -0000 From: Daniel Jacobowitz To: Denis PILAT Cc: gdb-patches Subject: Re: [RFC] thread apply commands change selected frame Message-ID: <20070121173341.GG12463@nevyn.them.org> Mail-Followup-To: Denis PILAT , gdb-patches References: <45A61E73.8030400@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45A61E73.8030400@st.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00440.txt.bz2 On Thu, Jan 11, 2007 at 12:24:35PM +0100, Denis PILAT wrote: > Hi everyone, > > I noticed a potential problem in thread.c: the "thread apply" commands > change the selected frame, I think it should not. > If you are doing > (gdb) up > (gdb) thread apply all print 1 > (gdb) down > then the frame selected before the up is not being restored by the down, > we have an error message instead. Yeah, that's a strange behavior. > I need your opinion before going ahead in this patch. It looks right to me. With a ChangeLog entry and testsuite results from some target with threads, it would be OK to commit. -- Daniel Jacobowitz CodeSourcery