Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,
	deuling@de.ibm.com, 	gdb-patches@sourceware.org
Subject: Re: [RFA]: gdb/testsuite/gdb.arch/altivec-regs.exp Broken testcase
Date: Sat, 20 Jan 2007 18:32:00 -0000	[thread overview]
Message-ID: <20070120183220.GB17653@nevyn.them.org> (raw)
In-Reply-To: <20070117055939.GA19331@nevyn.them.org>

On Wed, Jan 17, 2007 at 12:59:39AM -0500, Daniel Jacobowitz wrote:
> Looking at it now, it looks to me like I've got a condition backwards
> in show_endian.  The != should actually be an ==.  I can't test a patch
> for that until I get home next week though.

Home now.  I've tested and checked in this; sorry for the breakage.

-- 
Daniel Jacobowitz
CodeSourcery

2007-01-20  Daniel Jacobowitz  <dan@codesourcery.com>

	* arch-utils.c (show_endian): Correct reversed condition.

Index: arch-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/arch-utils.c,v
retrieving revision 1.138
diff -u -p -r1.138 arch-utils.c
--- arch-utils.c	13 Jan 2007 23:24:43 -0000	1.138
+++ arch-utils.c	20 Jan 2007 18:16:33 -0000
@@ -322,7 +322,7 @@ static void
 show_endian (struct ui_file *file, int from_tty, struct cmd_list_element *c,
 	     const char *value)
 {
-  if (target_byte_order_user != BFD_ENDIAN_UNKNOWN)
+  if (target_byte_order_user == BFD_ENDIAN_UNKNOWN)
     if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
       fprintf_unfiltered (file, _("The target endianness is set automatically "
 				  "(currently big endian)\n"));


      parent reply	other threads:[~2007-01-20 18:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16  6:48 Markus Deuling
2007-01-16 21:28 ` Mark Kettenis
2007-01-17  4:50   ` Markus Deuling
2007-01-17  5:59   ` Daniel Jacobowitz
2007-01-17  6:37     ` Markus Deuling
2007-01-17  8:31       ` Markus Deuling
2007-01-17 21:48       ` Mark Kettenis
2007-01-18  9:15         ` Markus Deuling
2007-01-20 18:32     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070120183220.GB17653@nevyn.them.org \
    --to=drow@false.org \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox