From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9924 invoked by alias); 20 Jan 2007 18:32:36 -0000 Received: (qmail 9910 invoked by uid 22791); 20 Jan 2007 18:32:36 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 20 Jan 2007 18:32:31 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H8L0m-0005cD-Ex; Sat, 20 Jan 2007 13:32:20 -0500 Date: Sat, 20 Jan 2007 18:32:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis , deuling@de.ibm.com, gdb-patches@sourceware.org Subject: Re: [RFA]: gdb/testsuite/gdb.arch/altivec-regs.exp Broken testcase Message-ID: <20070120183220.GB17653@nevyn.them.org> Mail-Followup-To: Mark Kettenis , deuling@de.ibm.com, gdb-patches@sourceware.org References: <45AC7532.6010108@de.ibm.com> <200701162128.l0GLS1U4024821@brahms.sibelius.xs4all.nl> <20070117055939.GA19331@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070117055939.GA19331@nevyn.them.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00418.txt.bz2 On Wed, Jan 17, 2007 at 12:59:39AM -0500, Daniel Jacobowitz wrote: > Looking at it now, it looks to me like I've got a condition backwards > in show_endian. The != should actually be an ==. I can't test a patch > for that until I get home next week though. Home now. I've tested and checked in this; sorry for the breakage. -- Daniel Jacobowitz CodeSourcery 2007-01-20 Daniel Jacobowitz * arch-utils.c (show_endian): Correct reversed condition. Index: arch-utils.c =================================================================== RCS file: /cvs/src/src/gdb/arch-utils.c,v retrieving revision 1.138 diff -u -p -r1.138 arch-utils.c --- arch-utils.c 13 Jan 2007 23:24:43 -0000 1.138 +++ arch-utils.c 20 Jan 2007 18:16:33 -0000 @@ -322,7 +322,7 @@ static void show_endian (struct ui_file *file, int from_tty, struct cmd_list_element *c, const char *value) { - if (target_byte_order_user != BFD_ENDIAN_UNKNOWN) + if (target_byte_order_user == BFD_ENDIAN_UNKNOWN) if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) fprintf_unfiltered (file, _("The target endianness is set automatically " "(currently big endian)\n"));