Re: [PATCH] Fix `testrun.log' output of manual `testrun's

[Jan Kratochvil <jan.kratochvil@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On Sat, 13 Jan 2007 17:00:55 +0100, Daniel Jacobowitz wrote:
...
> Does site.exp exist before this happens?  It has never happened to me;
> site.exp sets tool to gdb.

It does not exists as gdb has been built in a non-srcdir directory.


> I get a testrun.log if I run runtest before make site.exp, but then
> nothing works.

You are right.  While I believe the former patch makes the testsuite more
consistent I now see it makes no practical difference.

Rather proposing a new patch as only the warning message
	WARNING: No tool specified
was proven as not stopping the testsuite users in such local configurations.


Regards,
Jan

[-- Attachment #2: gdb-site-require.patch --]
[-- Type: text/plain, Size: 670 bytes --]

2007-01-14  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* lib/gdb.exp: Abort on missing `site.exp'.


diff -u -rup gdb-6.5-orig/gdb/testsuite/lib/gdb.exp gdb-6.5/gdb/testsuite/lib/gdb.exp
--- gdb-6.5-orig/gdb/testsuite/lib/gdb.exp	2006-12-17 11:59:42.000000000 +0100
+++ gdb-6.5/gdb/testsuite/lib/gdb.exp	2007-01-14 16:27:03.000000000 +0100
@@ -22,6 +22,12 @@
 # need to be modified for any target, it can be done with a variable
 # or by passing arguments.
 
+if {$tool == ""} {
+    # Tests would fail, logs on get_compiler_info() would be missing.
+    send_error "`site.exp' not found, run `make site.exp'!\n"
+    exit 2
+}
+
 load_lib libgloss.exp
 
 global GDB