From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32206 invoked by alias); 14 Jan 2007 15:34:55 -0000 Received: (qmail 32125 invoked by uid 22791); 14 Jan 2007 15:34:54 -0000 X-Spam-Check-By: sourceware.org Received: from 195.22.55.53.adsl.nextra.cz (HELO host0.dyn.jankratochvil.net) (195.22.55.53) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 14 Jan 2007 15:34:49 +0000 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.13.8/8.13.8) with ESMTP id l0EFYh5G003686; Sun, 14 Jan 2007 16:34:43 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.13.8/8.13.8/Submit) id l0EFYetg003685; Sun, 14 Jan 2007 16:34:40 +0100 Date: Sun, 14 Jan 2007 15:34:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Daniel Jacobowitz Subject: Re: [PATCH] Fix `testrun.log' output of manual `testrun's Message-ID: <20070114153437.GA2781@host0.dyn.jankratochvil.net> References: <20070113090837.GA25646@host0.dyn.jankratochvil.net> <20070113160055.GA28179@nevyn.them.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline In-Reply-To: <20070113160055.GA28179@nevyn.them.org> User-Agent: Mutt/1.4.2.2i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00344.txt.bz2 --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 633 On Sat, 13 Jan 2007 17:00:55 +0100, Daniel Jacobowitz wrote: ... > Does site.exp exist before this happens? It has never happened to me; > site.exp sets tool to gdb. It does not exists as gdb has been built in a non-srcdir directory. > I get a testrun.log if I run runtest before make site.exp, but then > nothing works. You are right. While I believe the former patch makes the testsuite more consistent I now see it makes no practical difference. Rather proposing a new patch as only the warning message WARNING: No tool specified was proven as not stopping the testsuite users in such local configurations. Regards, Jan --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-site-require.patch" Content-length: 670 2007-01-14 Jan Kratochvil * lib/gdb.exp: Abort on missing `site.exp'. diff -u -rup gdb-6.5-orig/gdb/testsuite/lib/gdb.exp gdb-6.5/gdb/testsuite/lib/gdb.exp --- gdb-6.5-orig/gdb/testsuite/lib/gdb.exp 2006-12-17 11:59:42.000000000 +0100 +++ gdb-6.5/gdb/testsuite/lib/gdb.exp 2007-01-14 16:27:03.000000000 +0100 @@ -22,6 +22,12 @@ # need to be modified for any target, it can be done with a variable # or by passing arguments. +if {$tool == ""} { + # Tests would fail, logs on get_compiler_info() would be missing. + send_error "`site.exp' not found, run `make site.exp'!\n" + exit 2 +} + load_lib libgloss.exp global GDB --9jxsPFA5p3P2qPhR--