Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix mi-basics.exp
Date: Fri, 12 Jan 2007 18:03:00 -0000	[thread overview]
Message-ID: <20070112180324.GA30005@nevyn.them.org> (raw)
In-Reply-To: <17829.29304.465815.173045@kahikatea.snap.net.nz>

On Thu, Jan 11, 2007 at 12:10:48PM +1300, Nick Roberts wrote:
> [2nd attempt, I'm not sure where the first post ended up]
> 
> This is to fix the annoying fails that occur in mi-basics.exp when srcdir is a
> relative pathname in site.exp.  It uses objdir instead of srcdir for the tests
> which always seems to be an absolute filename, although I don't know where
> runtest gets its value.
> 
> If approved, I'll make the same change for mi2-basics.exp.

OK, and thanks a lot for fixing this.  objdir is fine; it seems that
dejagnu always arranges to set that to a full path (unless you specify
it yourself in site.exp or on the command line, which we don't).

> --- 221,234 ----
>       }
>   
>       set orig_path [string_to_regexp ${orig_path}]
> +     set pathdir [string_to_regexp ${objdir}/${subdir}]
>   
>       mi_gdb_test "207-environment-path" \
>                "207\\\^done,path=\"$orig_path\"" \
>                "environment-path no-args operation"
>   
> !     mi_gdb_test "208-environment-path $objdir ${objdir}/${subdir}" \
> !              "208\\\^done,path=\"$escapedobjdir.${envirodir}.$orig_path\"" \
>                "environment-path dir1 dir2 operation"
>   
>       mi_gdb_test "209-environment-path -r $objdir" \

I think pathdir is unused.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-01-12 18:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-10 23:11 Nick Roberts
2007-01-12 18:03 ` Daniel Jacobowitz [this message]
2007-01-12 21:40   ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070112180324.GA30005@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox