From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18205 invoked by alias); 12 Jan 2007 18:03:36 -0000 Received: (qmail 18194 invoked by uid 22791); 12 Jan 2007 18:03:35 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 12 Jan 2007 18:03:27 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H5QkO-0007ux-Nf; Fri, 12 Jan 2007 13:03:24 -0500 Date: Fri, 12 Jan 2007 18:03:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix mi-basics.exp Message-ID: <20070112180324.GA30005@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17829.29304.465815.173045@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17829.29304.465815.173045@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00317.txt.bz2 On Thu, Jan 11, 2007 at 12:10:48PM +1300, Nick Roberts wrote: > [2nd attempt, I'm not sure where the first post ended up] > > This is to fix the annoying fails that occur in mi-basics.exp when srcdir is a > relative pathname in site.exp. It uses objdir instead of srcdir for the tests > which always seems to be an absolute filename, although I don't know where > runtest gets its value. > > If approved, I'll make the same change for mi2-basics.exp. OK, and thanks a lot for fixing this. objdir is fine; it seems that dejagnu always arranges to set that to a full path (unless you specify it yourself in site.exp or on the command line, which we don't). > --- 221,234 ---- > } > > set orig_path [string_to_regexp ${orig_path}] > + set pathdir [string_to_regexp ${objdir}/${subdir}] > > mi_gdb_test "207-environment-path" \ > "207\\\^done,path=\"$orig_path\"" \ > "environment-path no-args operation" > > ! mi_gdb_test "208-environment-path $objdir ${objdir}/${subdir}" \ > ! "208\\\^done,path=\"$escapedobjdir.${envirodir}.$orig_path\"" \ > "environment-path dir1 dir2 operation" > > mi_gdb_test "209-environment-path -r $objdir" \ I think pathdir is unused. -- Daniel Jacobowitz CodeSourcery