Re: MI testsuite failures [PATCH]

[Daniel Jacobowitz <drow@false.org>]

On Tue, Jan 09, 2007 at 11:33:21AM +1300, Nick Roberts wrote:
>  > This is the same reason you had to add spurious -var-update's to the
>  > testsuite.  
> 
> I don't know that I'd call them spurious.  The command -var-assign seems a bit
> anomalous to me.  It could just set the value like "set var i=10".  I think the
> updating of variable objects should be left to -var-update, but this change
> might be too radical at this stage.

I think it's right the way it is; if you want that behavior, you could
use -data-evaluate-expression to assign instead of -var-assign (well,
you'd need resolution on -var-info-path-expression first).  -var-assign
is documented to assign to the variable object, not just the variable.

Anyway, easily adjusted later, if we want.

> I think that's the best we can do; the `string' will be displayed differently
> in the watch window.

I agree.

>  > 2007-01-08  Daniel Jacobowitz  <dan@codesourcery.com>
>  > 
>  > 	* varobj.c (install_new_value): Always update print_value.
>  > 	(value_get_print_value): Immediately return NULL for missing
>  > 	values.
>  > 
>  > 2007-01-08  Nick Roberts  <nickrob@snap.net.nz>
>  > 	    Daniel Jacobowitz  <dan@codesourcery.com>
>  > 
>  > 	* gdb.mi/mi-var-cmd.exp: Expect lpcharacter to update when
>  > 	lcharacter or linteger change.  Correct duplicated test name.
>  > 	* gdb.mi/mi2-var-cmd.exp: Likewise.
> 
> Yes, I'd be happy to see these changes installed.

Thanks for looking at it.  I'll check them in shortly.

-- 
Daniel Jacobowitz
CodeSourcery