From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18482 invoked by alias); 8 Jan 2007 22:45:39 -0000 Received: (qmail 18411 invoked by uid 22791); 8 Jan 2007 22:45:38 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 08 Jan 2007 22:45:28 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H43F8-0007dE-3K; Mon, 08 Jan 2007 17:45:26 -0500 Date: Mon, 08 Jan 2007 22:45:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: MI testsuite failures [PATCH] Message-ID: <20070108224526.GA28903@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17825.33653.885121.321357@kahikatea.snap.net.nz> <17825.56391.466504.569955@kahikatea.snap.net.nz> <20070108171149.GC15412@nevyn.them.org> <17826.50865.340113.767106@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17826.50865.340113.767106@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00247.txt.bz2 On Tue, Jan 09, 2007 at 11:33:21AM +1300, Nick Roberts wrote: > > This is the same reason you had to add spurious -var-update's to the > > testsuite. > > I don't know that I'd call them spurious. The command -var-assign seems a bit > anomalous to me. It could just set the value like "set var i=10". I think the > updating of variable objects should be left to -var-update, but this change > might be too radical at this stage. I think it's right the way it is; if you want that behavior, you could use -data-evaluate-expression to assign instead of -var-assign (well, you'd need resolution on -var-info-path-expression first). -var-assign is documented to assign to the variable object, not just the variable. Anyway, easily adjusted later, if we want. > I think that's the best we can do; the `string' will be displayed differently > in the watch window. I agree. > > 2007-01-08 Daniel Jacobowitz > > > > * varobj.c (install_new_value): Always update print_value. > > (value_get_print_value): Immediately return NULL for missing > > values. > > > > 2007-01-08 Nick Roberts > > Daniel Jacobowitz > > > > * gdb.mi/mi-var-cmd.exp: Expect lpcharacter to update when > > lcharacter or linteger change. Correct duplicated test name. > > * gdb.mi/mi2-var-cmd.exp: Likewise. > > Yes, I'd be happy to see these changes installed. Thanks for looking at it. I'll check them in shortly. -- Daniel Jacobowitz CodeSourcery