From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/ada] Improve is_known_support_routine
Date: Sun, 07 Jan 2007 23:38:00 -0000 [thread overview]
Message-ID: <20070107233832.GB28585@nevyn.them.org> (raw)
In-Reply-To: <20070106182652.GR15512@adacore.com>
On Sat, Jan 06, 2007 at 10:26:52PM +0400, Joel Brobecker wrote:
> The is_known_support_routine identifies any frame for which we cannot
> find the source file. The check we currently have in place is a bit too
> simplistic, so I replaced it with the function we use to locate source
> files:
>
> - if (stat (sal.symtab->filename, &st))
> + if (symtab_to_fullname (sal.symtab) == NULL)
Fine with me, although I wonder if "the source is missing" is really
the concept you want. Why should whether source for the runtime
library is present determine what we show? That would make the
feature more awkward to use for people who built their own libgnat and
still have the build tree.
Anyway, OK meanwhile.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-07 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 18:26 Joel Brobecker
2007-01-07 7:14 ` Joel Brobecker
2007-01-07 23:38 ` Daniel Jacobowitz [this message]
2007-01-08 3:30 ` Joel Brobecker
2007-01-08 3:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070107233832.GB28585@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox