From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27048 invoked by alias); 7 Jan 2007 23:38:42 -0000 Received: (qmail 27002 invoked by uid 22791); 7 Jan 2007 23:38:42 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 07 Jan 2007 23:38:37 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H3hay-0007Vj-LH; Sun, 07 Jan 2007 18:38:32 -0500 Date: Sun, 07 Jan 2007 23:38:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/ada] Improve is_known_support_routine Message-ID: <20070107233832.GB28585@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20070106182652.GR15512@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070106182652.GR15512@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00213.txt.bz2 On Sat, Jan 06, 2007 at 10:26:52PM +0400, Joel Brobecker wrote: > The is_known_support_routine identifies any frame for which we cannot > find the source file. The check we currently have in place is a bit too > simplistic, so I replaced it with the function we use to locate source > files: > > - if (stat (sal.symtab->filename, &st)) > + if (symtab_to_fullname (sal.symtab) == NULL) Fine with me, although I wonder if "the source is missing" is really the concept you want. Why should whether source for the runtime library is present determine what we show? That would make the feature more awkward to use for people who built their own libgnat and still have the build tree. Anyway, OK meanwhile. -- Daniel Jacobowitz CodeSourcery