From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align
Date: Fri, 05 Jan 2007 14:58:00 -0000 [thread overview]
Message-ID: <200701051458.l05EwAKw026568@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20070105143728.GV17211@adacore.com> (message from Joel Brobecker on Fri, 5 Jan 2007 18:37:28 +0400)
> Date: Fri, 5 Jan 2007 18:37:28 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> > Ah wait, that's true even for "absolute" code. I had a quick look at
> > the GCC code and it seems to always treat %ebx as callee-saved. So
> > I'm happy with leaving it out, but you could add a comment saying so
> > to prevent us from having this same discussion in about two months
> > ;-).
>
> Sure! How does the attached patch look? Does it contain enough info?
More than enough. Please commit after adding the missing space before
"GCC should never...".
> 2007-01-05 Joel Brobecker <brobecker@adacore.com>
>
> * i386-tdep.c (i386_analyze_stack_align): Add comment.
next prev parent reply other threads:[~2007-01-05 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 10:49 Joel Brobecker
2006-12-31 6:08 ` PING: " Joel Brobecker
2006-12-31 12:15 ` Mark Kettenis
2006-12-31 14:39 ` Joel Brobecker
2007-01-05 6:48 ` Joel Brobecker
2007-01-05 11:05 ` Mark Kettenis
2007-01-05 14:36 ` Joel Brobecker
2007-01-05 14:58 ` Mark Kettenis [this message]
2007-01-05 16:42 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701051458.l05EwAKw026568@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox