Re: PING: [RFA/i386] 2 more patterns in i386_analyze_stack_align

[Joel Brobecker <brobecker@adacore.com>]

> Hmm, you're missing the %ebx case here.  Now on ELF systems, you'll
> probably never see it since %ebx is used for GOT access, but on other
> object formats I don't think there is any reason why GCC wouldn't
> choose to use %ebx as well.

I can easily add the %ebx case as well, but I don't think GCC would
currently use that register in any configuration. I'll double-check
with one of my coworkers who told me about the other alternatives to
using %ecx, but it will have to wait for a few days until the holidays
are over. He told me about this after having looked at the code in GCC,
so I would be surprised if he did not see the %ebx case... Note that
even if GCC did not currently use %ebx, I don't mind adding support
for it, JIC.

> This looks reasonable otherwise, except that I would sort the patterns
> in a more logical order.

I sorted them in the order that GCC would use them. I don't mind sorting
them in a different order, if you like.

I will take this as approval, and wait for your comments to see if
you'd like me to submit followup patches: adding support for the use
of the %ebx case, and altering the patterns order.

Thanks Mark,
-- 
Joel