From: Vladimir Prus <ghost@cs.msu.su>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: -var-info-path-expression
Date: Fri, 05 Jan 2007 09:14:00 -0000 [thread overview]
Message-ID: <200701051214.18645.ghost@cs.msu.su> (raw)
In-Reply-To: <20070103223920.GN17935@nevyn.them.org>
On Thursday 04 January 2007 01:39, Daniel Jacobowitz wrote:
> On Mon, Dec 25, 2006 at 12:00:42PM +0300, Vladimir Prus wrote:
> >
> > This patch implements new MI command, -var-info-path-expression,
> > that, given a variable object, returns full expression that corresponds
> > to it. Both KDevelop and Eclipse have now code that guesses such
> > full expression, and that code is rather hacky, and not exactly correct.
> >
> > Moreover, as soon as MI is taught to get the true type
> > polymorphic C++ objects and display fields of the real type, such full expression
> > cannot be computed in frontend at all.
> >
> > The essence of this patch -- which expressions are returned in which cases -- are
> > ported without change from the Apple branch. The code structure is much
> > different though -- this patch capitalizes on MI refactoring patches I've posted
> > recently.
> >
> > This is lightly tested by hand, I'll write automated tests later. There's no docs
> > either -- again, will be written after discussion.
> >
> > There is a couple of issues with this patch:
> >
> > - I don't much like 'var-info-path-expression' name, but
> > naming of MI commands is not very important.
>
> True - I think it's fine.
>
> > - I'm not sure why we can't report full expression in the
> > output of -var-list-children. The code I have does not seem
> > very computationally expensive.
>
> Also true. If this would be more useful, I'd be happy to do it that
> way - would you still need -var-info-path-expression?
No, I think -var-info-path-expression will not be needed then. Except if we
do it that way, we'll have "all of test are broken because they don't expect
an extra field" situation. Grr. I'm not sure what to do here.
- Volodya
next prev parent reply other threads:[~2007-01-05 9:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-25 9:02 -var-info-path-expression Vladimir Prus
2007-01-03 22:39 ` -var-info-path-expression Daniel Jacobowitz
2007-01-05 9:14 ` Vladimir Prus [this message]
2007-01-27 21:49 ` -var-info-path-expression Vladimir Prus
2007-01-28 0:46 ` -var-info-path-expression Nick Roberts
2007-01-28 7:57 ` -var-info-path-expression Vladimir Prus
2007-01-28 8:35 ` -var-info-path-expression Nick Roberts
2007-01-29 10:53 ` -var-info-path-expression Vladimir Prus
2007-01-29 12:17 ` -var-info-path-expression Daniel Jacobowitz
2007-06-18 10:43 -var-info-path-expression Vladimir Prus
2007-06-18 19:40 ` -var-info-path-expression Eli Zaretskii
2007-06-21 5:15 ` -var-info-path-expression Vladimir Prus
2007-07-03 17:14 ` -var-info-path-expression Daniel Jacobowitz
2007-07-03 17:51 ` -var-info-path-expression Vladimir Prus
2007-07-03 17:58 ` -var-info-path-expression Daniel Jacobowitz
2007-08-22 11:23 -var-info-path-expression Vladimir Prus
2007-08-22 15:28 ` -var-info-path-expression Daniel Jacobowitz
2007-08-28 17:18 ` -var-info-path-expression Vladimir Prus
2007-08-28 19:55 ` -var-info-path-expression Eli Zaretskii
2007-08-31 9:08 ` -var-info-path-expression Eli Zaretskii
2007-08-31 9:57 ` -var-info-path-expression Vladimir Prus
2007-08-31 18:04 ` -var-info-path-expression Eli Zaretskii
2007-08-31 18:53 ` -var-info-path-expression Vladimir Prus
2007-09-01 7:56 ` -var-info-path-expression Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701051214.18645.ghost@cs.msu.su \
--to=ghost@cs.msu.su \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox