From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26019 invoked by alias); 5 Jan 2007 09:14:43 -0000 Received: (qmail 26009 invoked by uid 22791); 5 Jan 2007 09:14:42 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Jan 2007 09:14:38 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H2l9h-0007q9-Jb for gdb-patches@sources.redhat.com; Fri, 05 Jan 2007 12:14:34 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1H2l9Z-0007pm-99; Fri, 05 Jan 2007 12:14:21 +0300 From: Vladimir Prus To: Daniel Jacobowitz Subject: Re: -var-info-path-expression Date: Fri, 05 Jan 2007 09:14:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <200612251200.42622.ghost@cs.msu.su> <20070103223920.GN17935@nevyn.them.org> In-Reply-To: <20070103223920.GN17935@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701051214.18645.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00179.txt.bz2 On Thursday 04 January 2007 01:39, Daniel Jacobowitz wrote: > On Mon, Dec 25, 2006 at 12:00:42PM +0300, Vladimir Prus wrote: > > > > This patch implements new MI command, -var-info-path-expression, > > that, given a variable object, returns full expression that corresponds > > to it. Both KDevelop and Eclipse have now code that guesses such > > full expression, and that code is rather hacky, and not exactly correct. > > > > Moreover, as soon as MI is taught to get the true type > > polymorphic C++ objects and display fields of the real type, such full expression > > cannot be computed in frontend at all. > > > > The essence of this patch -- which expressions are returned in which cases -- are > > ported without change from the Apple branch. The code structure is much > > different though -- this patch capitalizes on MI refactoring patches I've posted > > recently. > > > > This is lightly tested by hand, I'll write automated tests later. There's no docs > > either -- again, will be written after discussion. > > > > There is a couple of issues with this patch: > > > > - I don't much like 'var-info-path-expression' name, but > > naming of MI commands is not very important. > > True - I think it's fine. > > > - I'm not sure why we can't report full expression in the > > output of -var-list-children. The code I have does not seem > > very computationally expensive. > > Also true. If this would be more useful, I'd be happy to do it that > way - would you still need -var-info-path-expression? No, I think -var-info-path-expression will not be needed then. Except if we do it that way, we'll have "all of test are broken because they don't expect an extra field" situation. Grr. I'm not sure what to do here. - Volodya