Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Simplified MI tests
Date: Wed, 03 Jan 2007 23:14:00 -0000	[thread overview]
Message-ID: <20070103231355.GT17935@nevyn.them.org> (raw)
In-Reply-To: <200612201417.30428.vladimir@codesourcery.com>

On Wed, Dec 20, 2006 at 02:17:30PM +0300, Vladimir Prus wrote:
> I've converted one of MI tests to use this mechanism and found that
> the result is much more clear than it was. There are problems --
> namely that the syntax of the special comments looks weird and that
> Emacs does not highlight them as Tcl. But I think those I minor
> glitches and the new way is overall better?
> 
> OK?

No one commented, and overall I think it's a good idea.  I'll approve
the patch if you'll fix one thing for me...

> +        if {$first==1} {
> +            # Start the program afresh.
> +            set line_now [mi_run_to_line "$mi_autotest_source:$line"\
> +                          "exec-run"]
> +            set first 0
> +        } elseif {$line_now!=$line} {
> +            set line_now [mi_run_to_line "$mi_autotest_source:$line"\
> +                          "exec-continue"]
> +        }

Instead of using exec-run, can you arrange to use mi_runto, or at least
mi_run_cmd?  You can't "run" a remote target, e.g. gdbserver or
foo-elf.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-01-03 23:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20 11:18 Vladimir Prus
2007-01-03 23:14 ` Daniel Jacobowitz [this message]
2007-01-04 18:14   ` Vladimir Prus
2007-01-04 19:30     ` Daniel Jacobowitz
2007-01-04 20:13       ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070103231355.GT17935@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox