From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11891 invoked by alias); 3 Jan 2007 23:14:03 -0000 Received: (qmail 11883 invoked by uid 22791); 3 Jan 2007 23:14:02 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 03 Jan 2007 23:13:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H2FIx-0007NX-EY; Wed, 03 Jan 2007 18:13:55 -0500 Date: Wed, 03 Jan 2007 23:14:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Simplified MI tests Message-ID: <20070103231355.GT17935@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200612201417.30428.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200612201417.30428.vladimir@codesourcery.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00095.txt.bz2 On Wed, Dec 20, 2006 at 02:17:30PM +0300, Vladimir Prus wrote: > I've converted one of MI tests to use this mechanism and found that > the result is much more clear than it was. There are problems -- > namely that the syntax of the special comments looks weird and that > Emacs does not highlight them as Tcl. But I think those I minor > glitches and the new way is overall better? > > OK? No one commented, and overall I think it's a good idea. I'll approve the patch if you'll fix one thing for me... > + if {$first==1} { > + # Start the program afresh. > + set line_now [mi_run_to_line "$mi_autotest_source:$line"\ > + "exec-run"] > + set first 0 > + } elseif {$line_now!=$line} { > + set line_now [mi_run_to_line "$mi_autotest_source:$line"\ > + "exec-continue"] > + } Instead of using exec-run, can you arrange to use mi_runto, or at least mi_run_cmd? You can't "run" a remote target, e.g. gdbserver or foo-elf. -- Daniel Jacobowitz CodeSourcery