From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Return value cleanup in rs6000-tdep.c
Date: Tue, 02 Jan 2007 05:24:00 -0000 [thread overview]
Message-ID: <20070102052456.GE17211@adacore.com> (raw)
In-Reply-To: <200701011746.l01HkAT8016192@brahms.sibelius.xs4all.nl>
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * rs6000-tdep.c (rs6000_use_struct_convention)
> (rs6000_extract_return_value, rs6000_store_return_value)
> (rs6000_extract_struct_value_address): Remove.
> (rs6000_return_value): New function.
> (rs6000_gdbarch_init): Don't set deprecated_extract_return_value,
> store_return_value, deprecated_extract_struct_value_address and
> deprecated_use_struct_convention. Use rs6000_return_value
> instead.
The planets must be in the right alignment. The testsuite took way less
time to complete than the actual build. Here are the only differences
(before and after):
* gdb.base:
+------------+------------+----------------------------------------------------+
| FAIL | PASS | call-sc.exp: value foo returned; return call-sc-tc |
| FAIL | PASS | call-sc.exp: value foo returned; return call-sc-ts |
| FAIL | PASS | call-sc.exp: value foo returned; return call-sc-tf |
| FAIL | PASS | return2.exp: char value returned successfully |
| FAIL | PASS | return2.exp: short value returned successfully |
| FAIL | PASS | return2.exp: validate result value not equal t ... |
| | | ... o program return value |
| FAIL | PASS | return2.exp: float value returned successfully |
+------------+------------+----------------------------------------------------+
Thanks a lot for this patch, Mark.
--
Joel
next prev parent reply other threads:[~2007-01-02 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 17:46 Mark Kettenis
2007-01-02 3:50 ` Joel Brobecker
2007-01-02 5:24 ` Joel Brobecker [this message]
2007-01-02 19:22 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102052456.GE17211@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox