From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2379 invoked by alias); 2 Jan 2007 05:24:18 -0000 Received: (qmail 2368 invoked by uid 22791); 2 Jan 2007 05:24:17 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Jan 2007 05:24:12 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 333A748CBF8; Tue, 2 Jan 2007 00:24:10 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 02873-01-10; Tue, 2 Jan 2007 00:24:10 -0500 (EST) Received: from takamaka.act-europe.fr (AStDenis-105-1-58-225.w80-8.abo.wanadoo.fr [80.8.155.225]) by nile.gnat.com (Postfix) with ESMTP id 45B4048CBDA; Tue, 2 Jan 2007 00:24:09 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 5C0C734C099; Tue, 2 Jan 2007 09:24:56 +0400 (RET) Date: Tue, 02 Jan 2007 05:24:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Return value cleanup in rs6000-tdep.c Message-ID: <20070102052456.GE17211@adacore.com> References: <200701011746.l01HkAT8016192@brahms.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701011746.l01HkAT8016192@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00041.txt.bz2 > Index: ChangeLog > from Mark Kettenis > > * rs6000-tdep.c (rs6000_use_struct_convention) > (rs6000_extract_return_value, rs6000_store_return_value) > (rs6000_extract_struct_value_address): Remove. > (rs6000_return_value): New function. > (rs6000_gdbarch_init): Don't set deprecated_extract_return_value, > store_return_value, deprecated_extract_struct_value_address and > deprecated_use_struct_convention. Use rs6000_return_value > instead. The planets must be in the right alignment. The testsuite took way less time to complete than the actual build. Here are the only differences (before and after): * gdb.base: +------------+------------+----------------------------------------------------+ | FAIL | PASS | call-sc.exp: value foo returned; return call-sc-tc | | FAIL | PASS | call-sc.exp: value foo returned; return call-sc-ts | | FAIL | PASS | call-sc.exp: value foo returned; return call-sc-tf | | FAIL | PASS | return2.exp: char value returned successfully | | FAIL | PASS | return2.exp: short value returned successfully | | FAIL | PASS | return2.exp: validate result value not equal t ... | | | | ... o program return value | | FAIL | PASS | return2.exp: float value returned successfully | +------------+------------+----------------------------------------------------+ Thanks a lot for this patch, Mark. -- Joel