From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Two identical "else if" blocks ?
Date: Mon, 01 Jan 2007 04:01:00 -0000 [thread overview]
Message-ID: <20070101040118.GA2035@nevyn.them.org> (raw)
In-Reply-To: <20070101035248.GE3428@adacore.com>
On Mon, Jan 01, 2007 at 07:52:49AM +0400, Joel Brobecker wrote:
> It looks like the two blocks are completely identical, and we should
> be able to remove one of them. Should I perhaps test what happens
> when I delete, say, the first one?
They're not 100% the same (there's an extra b->inserted check) so I'd
recommend deleting the second one, since it's dead code.
Looks like they've been the same since at least the dawn of CVS.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-01 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 3:52 Joel Brobecker
2007-01-01 4:01 ` Daniel Jacobowitz [this message]
2007-01-01 14:12 ` [commit] (was: "Re: Two identical "else if" blocks ?") Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070101040118.GA2035@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox