From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14643 invoked by alias); 1 Jan 2007 04:01:25 -0000 Received: (qmail 14635 invoked by uid 22791); 1 Jan 2007 04:01:25 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 01 Jan 2007 04:01:20 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H1EMQ-0000XC-Dv; Sun, 31 Dec 2006 23:01:18 -0500 Date: Mon, 01 Jan 2007 04:01:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: Two identical "else if" blocks ? Message-ID: <20070101040118.GA2035@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20070101035248.GE3428@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070101035248.GE3428@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00004.txt.bz2 On Mon, Jan 01, 2007 at 07:52:49AM +0400, Joel Brobecker wrote: > It looks like the two blocks are completely identical, and we should > be able to remove one of them. Should I perhaps test what happens > when I delete, say, the first one? They're not 100% the same (there's an extra b->inserted check) so I'd recommend deleting the second one, since it's dead code. Looks like they've been the same since at least the dawn of CVS. -- Daniel Jacobowitz CodeSourcery