From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Cleanup mi_cmd_data_write_register_values
Date: Mon, 01 Jan 2007 03:07:00 -0000 [thread overview]
Message-ID: <20070101030705.GA685@nevyn.them.org> (raw)
In-Reply-To: <200701010145.l011j8FY027694@brahms.sibelius.xs4all.nl>
On Mon, Jan 01, 2007 at 02:45:08AM +0100, Mark Kettenis wrote:
> The next victim in my vendetta agains deprecated_xxx.
Thankyou thankyou! This is a great thing to do. I've been meaning to
do it myself, but I decided that my background cleanup project for now
would be testsuite results.
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * mi/mi-main.c (mi_cmd_data_write_register_values): Use
> regcache_cooked_write_signed instead of
> deprecated_write_register_bytes.
Patch looks OK. I'm almost glad this command is undocumented; this is
really all wrong as can be, since registers might not fit in the
LONGEST, and especially floating point registers have no business being
set from integer bit patterns. And it encourages sloppy frontends to
hard code register numbers. Yuck.
> + if (regnum >= 0 && regnum < numregs
> + && REGISTER_NAME (regnum) && *REGISTER_NAME (regnum))
Extra space in the middle there.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-01 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 1:45 Mark Kettenis
2007-01-01 3:07 ` Daniel Jacobowitz [this message]
2007-01-01 23:33 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070101030705.GA685@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox