From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18459 invoked by alias); 1 Jan 2007 03:07:15 -0000 Received: (qmail 18449 invoked by uid 22791); 1 Jan 2007 03:07:13 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 01 Jan 2007 03:07:08 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H1DVx-0000GF-O8; Sun, 31 Dec 2006 22:07:05 -0500 Date: Mon, 01 Jan 2007 03:07:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Cleanup mi_cmd_data_write_register_values Message-ID: <20070101030705.GA685@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <200701010145.l011j8FY027694@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200701010145.l011j8FY027694@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00002.txt.bz2 On Mon, Jan 01, 2007 at 02:45:08AM +0100, Mark Kettenis wrote: > The next victim in my vendetta agains deprecated_xxx. Thankyou thankyou! This is a great thing to do. I've been meaning to do it myself, but I decided that my background cleanup project for now would be testsuite results. > Index: ChangeLog > from Mark Kettenis > > * mi/mi-main.c (mi_cmd_data_write_register_values): Use > regcache_cooked_write_signed instead of > deprecated_write_register_bytes. Patch looks OK. I'm almost glad this command is undocumented; this is really all wrong as can be, since registers might not fit in the LONGEST, and especially floating point registers have no business being set from integer bit patterns. And it encourages sloppy frontends to hard code register numbers. Yuck. > + if (regnum >= 0 && regnum < numregs > + && REGISTER_NAME (regnum) && *REGISTER_NAME (regnum)) Extra space in the middle there. -- Daniel Jacobowitz CodeSourcery