From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA] Add support for catch Ada exceptions
Date: Sun, 31 Dec 2006 04:39:00 -0000 [thread overview]
Message-ID: <20061231044020.GO3640@adacore.com> (raw)
In-Reply-To: <ubqll2xap.fsf@gnu.org>
> > (gdb) catch exception
> > Catchpoint 1 on all Ada exceptions at 0x804b7c0
> > (gdb) info break
> > Num Type Disp Enb Address What
> > 1 catch exception keep y 0x0804b7c0 on all Ada exceptions
>
> I don't like this ``on'' business. How about removing it?
Sure, that's a good idea.
> > (gdb) catch exception unhandled
> > Catchpoint 3 on unhandled Ada exceptions at 0x804ad2d
>
> Again, removing the ``on'' part makes it sound better, IMO:
>
> (gdb) catch exception program_error
> Catchpoint 1: `program_error' Ada exception at 0x804b7c0
Ditto.
> Btw, do we need to display the address? The fact that you actually
> implement this as breakpoints is an implementation detail; the user
> doesn't need to know, I think.
You are right, displaying the addresses can be confusing.
I will resend a new patch shortly... Thanks for the feedback!
--
Joel
next prev parent reply other threads:[~2006-12-31 4:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-30 3:20 Joel Brobecker
2006-12-30 15:55 ` Eli Zaretskii
2006-12-31 4:39 ` Joel Brobecker [this message]
2006-12-31 21:37 ` Daniel Jacobowitz
2007-01-01 4:42 ` Joel Brobecker
2007-01-01 16:19 ` Daniel Jacobowitz
2007-01-02 6:06 ` [RFA] Add support for catch Ada exceptions (take 2) Joel Brobecker
2007-01-02 6:15 ` Joel Brobecker
2007-01-03 2:47 ` Daniel Jacobowitz
2007-01-04 5:32 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061231044020.GO3640@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox