From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1331 invoked by alias); 31 Dec 2006 04:39:44 -0000 Received: (qmail 1318 invoked by uid 22791); 31 Dec 2006 04:39:41 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 31 Dec 2006 04:39:34 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id F326348CC1F; Sat, 30 Dec 2006 23:39:32 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 15894-01-2; Sat, 30 Dec 2006 23:39:32 -0500 (EST) Received: from takamaka.act-europe.fr (AStDenis-105-1-28-173.w81-248.abo.wanadoo.fr [81.248.254.173]) by nile.gnat.com (Postfix) with ESMTP id 0B31448CBB2; Sat, 30 Dec 2006 23:39:32 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id BEC7D34C099; Sun, 31 Dec 2006 08:40:20 +0400 (RET) Date: Sun, 31 Dec 2006 04:39:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFC/RFA] Add support for catch Ada exceptions Message-ID: <20061231044020.GO3640@adacore.com> References: <20061230032111.GB27642@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00388.txt.bz2 > > (gdb) catch exception > > Catchpoint 1 on all Ada exceptions at 0x804b7c0 > > (gdb) info break > > Num Type Disp Enb Address What > > 1 catch exception keep y 0x0804b7c0 on all Ada exceptions > > I don't like this ``on'' business. How about removing it? Sure, that's a good idea. > > (gdb) catch exception unhandled > > Catchpoint 3 on unhandled Ada exceptions at 0x804ad2d > > Again, removing the ``on'' part makes it sound better, IMO: > > (gdb) catch exception program_error > Catchpoint 1: `program_error' Ada exception at 0x804b7c0 Ditto. > Btw, do we need to display the address? The fact that you actually > implement this as breakpoints is an implementation detail; the user > doesn't need to know, I think. You are right, displaying the addresses can be confusing. I will resend a new patch shortly... Thanks for the feedback! -- Joel