[patch] Add support for fido.

[patch] Add support for fido.

[Kazu Hirata]

Hi,

Attached is a patch to add support for fido, a new chip from Innovasic
Semiconductor.

Tested by building gdb and running "Hello, world".  OK to apply?

Kazu Hirata

gdb/
2006-12-25  Kazu Hirata  <kazu@codesourcery.com>

	* configure.tgt: Recognize fido.
	* config/m68k/fido.mt, config/m68k/tm-fido.h: New.

Index: gdb/configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.181
diff -u -d -p -r1.181 configure.tgt
--- gdb/configure.tgt	15 Dec 2006 23:45:04 -0000	1.181
+++ gdb/configure.tgt	26 Dec 2006 01:59:26 -0000
@@ -14,6 +14,7 @@ alpha*)			gdb_target_cpu=alpha ;;
 am33_2.0*)              gdb_target_cpu=mn10300 ;;
 arm*)			gdb_target_cpu=arm ;;
 avr*)			gdb_target_cpu=avr ;;
+fido*)			gdb_target_cpu=m68k ;;
 hppa*)			gdb_target_cpu=pa ;;
 i[34567]86*)		gdb_target_cpu=i386 ;;
 m68hc11*|m6811*)	gdb_target_cpu=m68hc11 ;;
@@ -75,6 +76,8 @@ cris*)                  gdb_target=cris 
 
 # OBSOLETE d10v-*-*)		gdb_target=d10v ;;
 
+fido-*-elf*)		gdb_target=fido ;;
+
 frv-*-*)		gdb_target=frv ;;
 
 h8300-*-*)		gdb_target=h8300 ;;
Index: gdb/config/m68k/fido.mt
===================================================================
RCS file: gdb/config/m68k/fido.mt
diff -N gdb/config/m68k/fido.mt
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gdb/config/m68k/fido.mt	26 Dec 2006 01:59:26 -0000
@@ -0,0 +1,3 @@
+# Target: Motorola m68k embedded (EST emulator, rom68k and bug monitors)
+TDEPFILES= m68k-tdep.o monitor.o dbug-rom.o dsrec.o
+DEPRECATED_TM_FILE = tm-fido.h
Index: gdb/config/m68k/tm-fido.h
===================================================================
RCS file: gdb/config/m68k/tm-fido.h
diff -N gdb/config/m68k/tm-fido.h
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gdb/config/m68k/tm-fido.h	26 Dec 2006 01:59:26 -0000
@@ -0,0 +1,28 @@
+/* Target machine definitions for a generic m68k monitor/emulator.
+   Copyright 2006
+   Free Software Foundation, Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+/* Watchpoints are always continuable for these targets.  There's no
+   multi-arch way to set this yet since it still lives in the target
+   vector.
+
+   FIXME: If the Fido port is ever submitted, this should move to
+   gdbarch.  */
+#define HAVE_CONTINUABLE_WATCHPOINT 1

Re: [patch] Add support for fido.

[Daniel Jacobowitz]

On Mon, Dec 25, 2006 at 06:03:47PM -0800, Kazu Hirata wrote:
> +/* Watchpoints are always continuable for these targets.  There's no
> +   multi-arch way to set this yet since it still lives in the target
> +   vector.
> +
> +   FIXME: If the Fido port is ever submitted, this should move to
> +   gdbarch.  */
> +#define HAVE_CONTINUABLE_WATCHPOINT 1

Did you read my comment there? :-)

I admit I'm not quite sure what to do about it.  Because of the sorts
of targets which define HAVE_CONTINUABLE_WATCHPOINT, this may be
difficult to untangle.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] Add support for fido.

[Mark Kettenis]

> Date: Mon, 25 Dec 2006 18:03:47 -0800
> From: Kazu Hirata <kazu@codesourcery.com>
> 
> Hi,
> 
> Attached is a patch to add support for fido, a new chip from Innovasic
> Semiconductor.
> 
> Tested by building gdb and running "Hello, world".  OK to apply?

> +/* Watchpoints are always continuable for these targets.  There's no
> +   multi-arch way to set this yet since it still lives in the target
> +   vector.
> +
> +   FIXME: If the Fido port is ever submitted, this should move to
> +   gdbarch.  */
> +#define HAVE_CONTINUABLE_WATCHPOINT 1

This suggests it isn't!

Mark

Re: [patch] Add support for fido.

[Daniel Jacobowitz]

On Thu, Oct 11, 2007 at 10:19:51AM -0400, Kazu Hirata wrote:
> Hi Daniel,
> 
> >> Attached is a patch to support for fido.
> >>
> >> Tested by running Hello, world from gdb.  OK to apply?
> > Does this simpler version work?
> >> +fido*)			gdb_target_cpu=m68k ;;
> > Keep this.
> >> +fido-*-elf*)		gdb_target=fido ;;
> > gdb_target=monitor
> 
> Yes, it does.  OK with that change (and without fido.mt)?

Yes, thanks.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] Add support for fido.

[Kazu Hirata]

Hi Daniel,

>> Attached is a patch to support for fido.
>>
>> Tested by running Hello, world from gdb.  OK to apply?
> 
> Does this simpler version work?
> 
>> +fido*)			gdb_target_cpu=m68k ;;
> 
> Keep this.
> 
>> +fido-*-elf*)		gdb_target=fido ;;
> 
> gdb_target=monitor

Yes, it does.  OK with that change (and without fido.mt)?

Kazu Hirata

Re: [patch] Add support for fido.

[Daniel Jacobowitz]

On Sun, Oct 07, 2007 at 11:12:33AM -0700, Kazu Hirata wrote:
> Hi,
> 
> Attached is a patch to support for fido.
> 
> Tested by running Hello, world from gdb.  OK to apply?

Does this simpler version work?

> +fido*)			gdb_target_cpu=m68k ;;

Keep this.

> +fido-*-elf*)		gdb_target=fido ;;

gdb_target=monitor

> --- /dev/null	2007-05-10 18:31:20.000000000 -0700
> +++ gdb/config/m68k/fido.mt	2007-10-07 10:13:36.000000000 -0700

Skip this file.

The only thing we needed fido.mt for, originally, was
HAVE_CONTINUABLE_WATCHPOINT.  That is now effectively the default, so
there shouldn't be any difference between this and a normal m68k-elf
target.

-- 
Daniel Jacobowitz
CodeSourcery

[patch] Add support for fido.

[Kazu Hirata]

Hi,

Attached is a patch to support for fido.

Tested by running Hello, world from gdb.  OK to apply?

Kazu Hirata

2007-10-07  Kazu Hirata  <kazu@codesourcery.com>

	* configure.tgt: Recognize fido-*-elf.
	* config/m68k/fido.mt: New.

Index: gdb/configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.189
diff -u -d -p -r1.189 configure.tgt
--- gdb/configure.tgt	27 Apr 2007 13:19:48 -0000	1.189
+++ gdb/configure.tgt	7 Oct 2007 18:03:30 -0000
@@ -32,6 +32,7 @@ alpha*)			gdb_target_cpu=alpha ;;
 am33_2.0*)              gdb_target_cpu=mn10300 ;;
 arm*)			gdb_target_cpu=arm ;;
 avr*)			gdb_target_cpu=avr ;;
+fido*)			gdb_target_cpu=m68k ;;
 hppa*)			gdb_target_cpu=pa ;;
 i[34567]86*)		gdb_target_cpu=i386 ;;
 m68hc11*|m6811*)	gdb_target_cpu=m68hc11 ;;
@@ -94,6 +95,8 @@ avr-*-*)		gdb_target=avr ;;
 
 cris*)                  gdb_target=cris ;;
 
+fido-*-elf*)		gdb_target=fido ;;
+
 frv-*-*)		gdb_target=frv ;;
 
 h8300-*-*)		gdb_target=h8300 ;;
--- /dev/null	2007-05-10 18:31:20.000000000 -0700
+++ gdb/config/m68k/fido.mt	2007-10-07 10:13:36.000000000 -0700
@@ -0,0 +1,2 @@
+# Target: Motorola m68k embedded (EST emulator, rom68k and bug monitors)
+TDEPFILES= m68k-tdep.o monitor.o dbug-rom.o dsrec.o