From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Cleanup varobj children handling
Date: Fri, 22 Dec 2006 07:26:00 -0000 [thread overview]
Message-ID: <200612221026.33323.ghost@cs.msu.su> (raw)
In-Reply-To: <17803.32462.717366.776290@kahikatea.snap.net.nz>
On Friday 22 December 2006 09:44, Nick Roberts wrote:
> > > /* Every variable keeps a linked list of its children, described
> > > by the following structure. */
> > > /* FIXME: Deprecated. All should use vlist instead */
> > >
> > > Buy perhaps this is not relevant.
> >
> > The comment was written before vec.c was available, so it naturally
> > does not suggest vec.c.
>
> Before your change varobj.c had two (equivalent?) types of data structure:
> vstack and vlist.
Actually, three: vstack, varobj_child and vlist.
> After your change varobj.c has two (equivalent?) types of
> data structure: VEC and vlist.
That's one data type off, plus vec.h is generic code, not private to varobj.c
> Should VEC not also be used for vlist?
Ultimately, yes. But I primarily wanted to cleanup the list of children, so open
path for other changes.
vlist does not get in my way, yet ;-)
- Volodya
next prev parent reply other threads:[~2006-12-22 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 20:00 Vladimir Prus
2006-12-08 20:22 ` Vladimir Prus
2006-12-18 7:28 ` Vladimir Prus
2006-12-21 15:25 ` Vladimir Prus
2006-12-21 22:42 ` Nick Roberts
2006-12-22 6:18 ` Vladimir Prus
2006-12-22 6:49 ` Nick Roberts
2006-12-22 7:26 ` Vladimir Prus [this message]
2006-12-26 16:10 ` Daniel Jacobowitz
2006-12-26 20:50 ` Vladimir Prus
2006-12-30 14:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612221026.33323.ghost@cs.msu.su \
--to=ghost@cs.msu.su \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox