From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17038 invoked by alias); 22 Dec 2006 07:26:47 -0000 Received: (qmail 17030 invoked by uid 22791); 22 Dec 2006 07:26:46 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Dec 2006 07:26:41 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1Gxene-0003td-Gy for gdb-patches@sources.redhat.com; Fri, 22 Dec 2006 10:26:39 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1Gxena-0003tP-EK; Fri, 22 Dec 2006 10:26:34 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: Cleanup varobj children handling Date: Fri, 22 Dec 2006 07:26:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <200612082300.06688.ghost@cs.msu.su> <200612220918.15378.ghost@cs.msu.su> <17803.32462.717366.776290@kahikatea.snap.net.nz> In-Reply-To: <17803.32462.717366.776290@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200612221026.33323.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00306.txt.bz2 On Friday 22 December 2006 09:44, Nick Roberts wrote: > > > /* Every variable keeps a linked list of its children, described > > > by the following structure. */ > > > /* FIXME: Deprecated. All should use vlist instead */ > > > > > > Buy perhaps this is not relevant. > > > > The comment was written before vec.c was available, so it naturally > > does not suggest vec.c. > > Before your change varobj.c had two (equivalent?) types of data structure: > vstack and vlist. Actually, three: vstack, varobj_child and vlist. > After your change varobj.c has two (equivalent?) types of > data structure: VEC and vlist. That's one data type off, plus vec.h is generic code, not private to varobj.c > Should VEC not also be used for vlist? Ultimately, yes. But I primarily wanted to cleanup the list of children, so open path for other changes. vlist does not get in my way, yet ;-) - Volodya