Re: PATCH: Provde a pid to filename conversion for NetBSD

[Nick Hudson <skrll@netbsd.org>]

On Friday 15 December 2006 16:37, Daniel Jacobowitz wrote:
> On Fri, Dec 15, 2006 at 04:23:30PM +0000, Nick Hudson wrote:
> > > 2006-11-30  Nick Hudson  <skrll@netbsd.org>
> > >
> > >         * i386nbsd-nat.c: Include "nbsd-nat.h".
> > >         (_initialize_i386nbsd_nat): Update target vector to use
> > >         nbsd_pid_to_exec_file.
> > >
> > >         * config/i386/nbsdelf.mh (NATDEPFILES): Add nbsd-nat.o
> > >
> > >         * nbsd-nat.c: New file.
> > >         * nbsd-nat.h: New file.
> > >         * Makefile.in (ALLDEPFILES): Add nbsd-nat.c.
> > >         (nbsd_nat_h): New variable.
> > >         (nbsd-nat.o): New dependency.
> >
> > What needs to happen for this to go in?
>
> Someone needs to review it.  I was hoping that someone who actually
> used NetBSD would speak up :-)  If no one does, I'll do it myself.

I sent Jason Thorpe (current NetBSD maintainer) an email, but got not 
response. :(

> It looks generally fine.  Is this going to work for every NetBSD
> platform?  Should it be added to all of them, rather than just i386?
> Looks like GDB supports 11.

I have diffs to add support to all other NetBSD platforms which I committed to 
the NetBSD tree recently. I'll send those after this one goes in.

Thanks,
Nick