GDB doesn't compile on GNU/Linux

GDB doesn't compile on GNU/Linux

[Nick Roberts]

I can't get GDB to compile on GNU/Linux because of this change:


2006-11-28  Ulrich Weigand  <uweigand@de.ibm.com>

	* config/nm-linux.h: Do not include <signal.h>.


The change below seems to fix it.

-- 
Nick                                           http://www.inet.net.nz/~nickrob



2006-11-29  Nick Roberts  <nickrob@snap.net.nz>

	* linux-thread-db.c: Include <signal.h>.


*** linux-thread-db.c	29 Nov 2006 09:48:09 +1300	1.21
--- linux-thread-db.c	29 Nov 2006 10:03:35 +1300	
***************
*** 39,44 ****
--- 39,46 ----
  #include "gdbcore.h"
  #include "linux-nat.h"
  
+ #include <signal.h>
+ 
  #ifdef HAVE_GNU_LIBC_VERSION_H
  #include <gnu/libc-version.h>
  #endif

Re: GDB doesn't compile on GNU/Linux

[Daniel Jacobowitz]

On Wed, Nov 29, 2006 at 10:07:06AM +1300, Nick Roberts wrote:
> 2006-11-29  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* linux-thread-db.c: Include <signal.h>.

OK.  Wonder what implicitly pulled it in where Ulrich tested, but
it's not worth finding out.

-- 
Daniel Jacobowitz
CodeSourcery

Re: GDB doesn't compile on GNU/Linux

[Ulrich Weigand]

Daniel Jacobowitz wrote:
> On Wed, Nov 29, 2006 at 10:07:06AM +1300, Nick Roberts wrote:
> > 2006-11-29  Nick Roberts  <nickrob@snap.net.nz>
> > 
> > 	* linux-thread-db.c: Include <signal.h>.
> 
> OK.  Wonder what implicitly pulled it in where Ulrich tested, but
> it's not worth finding out.

It looks like the s390 version of sys/ucontext.h includes signal.h,
and sys/ucontext.h gets pulled in by sys/procfs.h.

Sorry for the breakage ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: GDB doesn't compile on GNU/Linux

[Nick Roberts]

Daniel Jacobowitz writes:
 > On Wed, Nov 29, 2006 at 10:07:06AM +1300, Nick Roberts wrote:
 > > 2006-11-29  Nick Roberts  <nickrob@snap.net.nz>
 > > 
 > > 	* linux-thread-db.c: Include <signal.h>.
 > 
 > OK.  Wonder what implicitly pulled it in where Ulrich tested, but
 > it's not worth finding out.

In his case, linux-thread-db.c probably didn't get rebuilt after his changes.
Nothing in the Makefile seems to depend on nm-linux.h.  I probably hadn't
updated this checkout since before 2006-10-19.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: GDB doesn't compile on GNU/Linux

[Ulrich Weigand]

Nick Roberts wrote:
> Daniel Jacobowitz writes:
>  > On Wed, Nov 29, 2006 at 10:07:06AM +1300, Nick Roberts wrote:
>  > > 2006-11-29  Nick Roberts  <nickrob@snap.net.nz>
>  > > 
>  > > 	* linux-thread-db.c: Include <signal.h>.
>  > 
>  > OK.  Wonder what implicitly pulled it in where Ulrich tested, but
>  > it's not worth finding out.
> 
> In his case, linux-thread-db.c probably didn't get rebuilt after his changes.

Actually, I did a complete rebuild from scratch ;-)   See the other mail
why it happened to work on s390-ibm-linux and s390x-ibm-linux anyway ...

> Nothing in the Makefile seems to depend on nm-linux.h.  I probably hadn't
> updated this checkout since before 2006-10-19.

I thought the nm.h dependencies are set up automagically during configure?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: GDB doesn't compile on GNU/Linux

[Daniel Jacobowitz]

On Tue, Nov 28, 2006 at 10:45:54PM +0100, Ulrich Weigand wrote:
> > Nothing in the Makefile seems to depend on nm-linux.h.  I probably hadn't
> > updated this checkout since before 2006-10-19.
> 
> I thought the nm.h dependencies are set up automagically during configure?

I don't think anything actually depends on nm.h, though, and we don't
have dependencies for things it includes either.

-- 
Daniel Jacobowitz
CodeSourcery

Re: GDB doesn't compile on GNU/Linux

[Nick Roberts]

 > > In his case, linux-thread-db.c probably didn't get rebuilt after his
 > > changes.
 > 
 > Actually, I did a complete rebuild from scratch ;-)   See the other mail
 > why it happened to work on s390-ibm-linux and s390x-ibm-linux anyway ...

Sorry, "possibly" would have been more polite than "probably"!

 > > Nothing in the Makefile seems to depend on nm-linux.h.  I probably hadn't
 > > updated this checkout since before 2006-10-19.
 > 
 > I thought the nm.h dependencies are set up automagically during configure?

My understanding of the config is quite shallow but I just noticed that when I
did a rebuild of a more recent checkout from the top-level with make (make
"CFLAGS=-g3" actually) it compiled OK.  This normally picks up any problems.


-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: GDB doesn't compile on GNU/Linux

[Ulrich Weigand]

Daniel Jacobowitz wrote:
> On Tue, Nov 28, 2006 at 10:45:54PM +0100, Ulrich Weigand wrote:
> > > Nothing in the Makefile seems to depend on nm-linux.h.  I probably hadn't
> > > updated this checkout since before 2006-10-19.
> > 
> > I thought the nm.h dependencies are set up automagically during configure?
> 
> I don't think anything actually depends on nm.h, though,

Well, $(defs_h) includes $(nm_h), and just about everything depends on
$(defs_h).  Indeed, if I touch config/s390/nm-linux.h (the main NAT_FILE
on s390-linux and symlinked to nm.h by configure), most everything gets
rebuilt.

> and we don't
> have dependencies for things it includes either.

*That* appears to be the problem.  If I touch config/nm-linux.h,
nothing gets rebuilt at all.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com