From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: Patch: Little improvement to delete breakpoint command
Date: Tue, 28 Nov 2006 17:25:00 -0000 [thread overview]
Message-ID: <20061128172458.GH21834@nevyn.them.org> (raw)
In-Reply-To: <456C7023.4050204@de.ibm.com>
On Tue, Nov 28, 2006 at 06:21:39PM +0100, Markus Deuling wrote:
> Hello,
>
> this little patch adds a break to the loop that is looking for
> breakpoints to delete in delete_command(). I think it is only necessary
> to find one breakpoint, there is no need to iterate further if found one.
>
> ===================================================================
> --- breakpoint.old 2006-11-28 17:08:11.000000000 +0100
> +++ breakpoint.c 2006-11-28 17:42:15.000000000 +0100
> @@ -6960,6 +6960,7 @@
> b->type != bp_overlay_event &&
> b->number >= 0)
> breaks_to_delete = 1;
> + break;
> }
>
> /* Ask user only if there are some breakpoints to delete. */
>
Did you test this? I'm pretty sure you're missing braces.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-11-28 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 17:22 Markus Deuling
2006-11-28 17:25 ` Daniel Jacobowitz [this message]
2006-11-28 17:35 ` Markus Deuling
2006-11-28 17:42 ` Daniel Jacobowitz
2006-11-28 17:53 ` Markus Deuling
2006-11-29 13:52 Markus Deuling
2007-01-21 17:43 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128172458.GH21834@nevyn.them.org \
--to=drow@false.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox