From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20428 invoked by alias); 28 Nov 2006 17:25:10 -0000 Received: (qmail 20368 invoked by uid 22791); 28 Nov 2006 17:25:09 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Nov 2006 17:24:59 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gp6hW-00062D-3P; Tue, 28 Nov 2006 12:24:58 -0500 Date: Tue, 28 Nov 2006 17:25:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: GDB Subject: Re: Patch: Little improvement to delete breakpoint command Message-ID: <20061128172458.GH21834@nevyn.them.org> Mail-Followup-To: Markus Deuling , GDB References: <456C7023.4050204@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <456C7023.4050204@de.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00331.txt.bz2 On Tue, Nov 28, 2006 at 06:21:39PM +0100, Markus Deuling wrote: > Hello, > > this little patch adds a break to the loop that is looking for > breakpoints to delete in delete_command(). I think it is only necessary > to find one breakpoint, there is no need to iterate further if found one. > > =================================================================== > --- breakpoint.old 2006-11-28 17:08:11.000000000 +0100 > +++ breakpoint.c 2006-11-28 17:42:15.000000000 +0100 > @@ -6960,6 +6960,7 @@ > b->type != bp_overlay_event && > b->number >= 0) > breaks_to_delete = 1; > + break; > } > > /* Ask user only if there are some breakpoints to delete. */ > Did you test this? I'm pretty sure you're missing braces. -- Daniel Jacobowitz CodeSourcery