Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Tom Marn <tom.marn@telargo.com>
Cc: gdb-patches@sourceware.org, matej.kupljen@telargo.com
Subject: Re: PATCH: stfiwx implementation for PowerPC gdb simulator
Date: Tue, 28 Nov 2006 16:07:00 -0000	[thread overview]
Message-ID: <20061128160737.GF17349@nevyn.them.org> (raw)
In-Reply-To: <45642EC1.2070709@telargo.com>

On Wed, Nov 22, 2006 at 12:04:33PM +0100, Tom Marn wrote:
> Hi
> 
> I append new optional instruction "stfiwx" for PowerPC 603/603e/604 needed 
> by gdb inside sim/ppc simulator. GNU gcc already generates binaries with 
> this instruction and the patch is essential for properly running binaries 
> on gdb simulator (target sim). Without this patch you will get: program 
> interrupt - illegal instruction (optional instruction not supported)

I would review this patch, except that I have no idea whether it's
correct.  I hope someone more familiar with PowerPC is able to look
at it.

I'd recommend not moving the instruction; I believe the comments are
section references to the manual from which the pseudocode came
originally.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-11-28 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22 11:04 Tom Marn
2006-11-28 16:07 ` Daniel Jacobowitz [this message]
2006-11-29  8:33   ` Tom Marn
2006-11-29 15:28 ` Andrew Cagney
2006-11-29 15:30   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061128160737.GF17349@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=matej.kupljen@telargo.com \
    --cc=tom.marn@telargo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox