From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31916 invoked by alias); 28 Nov 2006 16:07:50 -0000 Received: (qmail 31907 invoked by uid 22791); 28 Nov 2006 16:07:49 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Nov 2006 16:07:39 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gp5Uf-0005F6-FS; Tue, 28 Nov 2006 11:07:37 -0500 Date: Tue, 28 Nov 2006 16:07:00 -0000 From: Daniel Jacobowitz To: Tom Marn Cc: gdb-patches@sourceware.org, matej.kupljen@telargo.com Subject: Re: PATCH: stfiwx implementation for PowerPC gdb simulator Message-ID: <20061128160737.GF17349@nevyn.them.org> Mail-Followup-To: Tom Marn , gdb-patches@sourceware.org, matej.kupljen@telargo.com References: <45642EC1.2070709@telargo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45642EC1.2070709@telargo.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00315.txt.bz2 On Wed, Nov 22, 2006 at 12:04:33PM +0100, Tom Marn wrote: > Hi > > I append new optional instruction "stfiwx" for PowerPC 603/603e/604 needed > by gdb inside sim/ppc simulator. GNU gcc already generates binaries with > this instruction and the patch is essential for properly running binaries > on gdb simulator (target sim). Without this patch you will get: program > interrupt - illegal instruction (optional instruction not supported) I would review this patch, except that I have no idea whether it's correct. I hope someone more familiar with PowerPC is able to look at it. I'd recommend not moving the instruction; I believe the comments are section references to the manual from which the pseudocode came originally. -- Daniel Jacobowitz CodeSourcery