Re: Xtensa GDB port -- revised patch

[Daniel Jacobowitz <drow@false.org>]

On Thu, Oct 05, 2006 at 04:54:51PM -0700, Maxim Grigoriev wrote:
> Hi Daniel and GDB maintainers,
> 
> >>Can you use the previous frame's stack pointer instead?
> >>Is that going to work?
> 
> Yes, it works fine.
> 
> I've attached a modified patch.

Thanks.  This is almost OK.  There are a few small issues left:

  - The port needs a maintainer, and an entry in MAINTAINERS.  Who will
    be the maintainer?

  - I noticed that your prev_register recursively calls
    frame_register_unwind.  This isn't a big problem but it is
    incorrect.  If you defer to another frame, you should set
    e.g. realnump to point the number for the next frame.  See
    trad_frame_get_prev_register for an example.

  - There's one stray hunk:
> @@ -1330,7 +1332,6 @@
>  	done
>  
>  Makefile: Makefile.in config.status @frags@
> -	# Regenerate the Makefile and the tm.h / nm.h links.
>  	CONFIG_FILES=Makefile \

  - There's a few instances of operators without spaces around them,
    like "-=4" and "(op1)==0x6c" and "8? 8".  I don't think you need to
    go back and fix them at this point, but please be careful in the
    future.

With the first three things fixed, I think we could commit the patch.

-- 
Daniel Jacobowitz
CodeSourcery