From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13774 invoked by alias); 10 Nov 2006 20:39:29 -0000 Received: (qmail 13748 invoked by uid 22791); 10 Nov 2006 20:39:29 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 10 Nov 2006 20:39:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Gid9Y-0001Qg-Kv; Fri, 10 Nov 2006 15:39:08 -0500 Date: Fri, 10 Nov 2006 20:39:00 -0000 From: Daniel Jacobowitz To: Maxim Grigoriev Cc: gdb-patches@sources.redhat.com, Bob Wilson , Marc Gauthier Subject: Re: Xtensa GDB port -- revised patch Message-ID: <20061110203908.GC1115@nevyn.them.org> Mail-Followup-To: Maxim Grigoriev , gdb-patches@sources.redhat.com, Bob Wilson , Marc Gauthier References: <451B202C.3090804@hq.tensilica.com> <20060928011910.GA20142@nevyn.them.org> <45259B4B.3010101@hq.tensilica.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45259B4B.3010101@hq.tensilica.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00072.txt.bz2 On Thu, Oct 05, 2006 at 04:54:51PM -0700, Maxim Grigoriev wrote: > Hi Daniel and GDB maintainers, > > >>Can you use the previous frame's stack pointer instead? > >>Is that going to work? > > Yes, it works fine. > > I've attached a modified patch. Thanks. This is almost OK. There are a few small issues left: - The port needs a maintainer, and an entry in MAINTAINERS. Who will be the maintainer? - I noticed that your prev_register recursively calls frame_register_unwind. This isn't a big problem but it is incorrect. If you defer to another frame, you should set e.g. realnump to point the number for the next frame. See trad_frame_get_prev_register for an example. - There's one stray hunk: > @@ -1330,7 +1332,6 @@ > done > > Makefile: Makefile.in config.status @frags@ > - # Regenerate the Makefile and the tm.h / nm.h links. > CONFIG_FILES=Makefile \ - There's a few instances of operators without spaces around them, like "-=4" and "(op1)==0x6c" and "8? 8". I don't think you need to go back and fix them at this point, but please be careful in the future. With the first three things fixed, I think we could commit the patch. -- Daniel Jacobowitz CodeSourcery