Fix target remote pipe error message

Fix target remote pipe error message

[Vladimir Prus]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]


I've just run into this:

    (gdb) target remote | foobar
    (gdb) error starting child process ' foobar': 
          CreateProcess: No such file or directory

Note the leading space before 'foobar' in the error message. That might 
suggest that space between "|" and program name is the problem while it's 
not.

This patch fixes the error message. OK?

- Volodya

	* serial.c (serial_open): Strip leading spaces from program name
	when opening pipe.




[-- Attachment #2: serial.diff --]
[-- Type: text/x-diff, Size: 696 bytes --]

Index: serial.c
===================================================================
RCS file: /cvs/src/src/gdb/serial.c,v
retrieving revision 1.26
diff -u -r1.26 serial.c
--- serial.c	24 Apr 2006 21:00:13 -0000	1.26
+++ serial.c	3 Nov 2006 15:30:16 -0000
@@ -189,7 +189,10 @@
   else if (strncmp (name, "|", 1) == 0)
     {
       ops = serial_interface_lookup ("pipe");
-      open_name = name + 1; /* discard ``|'' */
+      /* discard ``|'' and any space before the command itself. */
+      ++open_name;
+      while (isspace (*open_name))
+	++open_name;
     }
   /* Check for a colon, suggesting an IP address/port pair.
      Do this *after* checking for all the interesting prefixes.  We

Re: Fix target remote pipe error message

[Daniel Jacobowitz]

On Fri, Nov 03, 2006 at 06:33:17PM +0300, Vladimir Prus wrote:
> This patch fixes the error message. OK?
> 
> - Volodya
> 
> 	* serial.c (serial_open): Strip leading spaces from program name
> 	when opening pipe.

OK.

> -      open_name = name + 1; /* discard ``|'' */
> +      /* discard ``|'' and any space before the command itself. */

Two spaces after period please.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Fix target remote pipe error message

[Mark Kettenis]

>  On Fri, Nov 03, 2006 at 06:33:17PM +0300, Vladimir Prus wrote:
> > This patch fixes the error message. OK?
> >
> > - Volodya
> >
> > 	* serial.c (serial_open): Strip leading spaces from program name
> > 	when opening pipe.
>
>  OK.
>
> > -      open_name = name + 1; /* discard ``|'' */
> > +      /* discard ``|'' and any space before the command itself. */
>
>  Two spaces after period please.

And start the sentence with a capital...