[PATCH] Re: [RFC] Replace deprecated_target_new_objfile_hook by observer?

["Ulrich Weigand" <uweigand@de.ibm.com>]

Joel Brobecker wrote:

> Would you mind submitting your change for inclusion? I could then
> leverage off of this change for the transition to observers.

Sure, here goes the patch again.

Tested on s390-ibm-linux and s390x-ibm-linux.
OK for mainline?

Bye,
Ulrich


ChangeLog:

        * linux-thread-db.c (check_for_thread_db): Don't attempt to use
        thread_db for remote targets.
        * remote.c (remote_new_objfile): Always call predecessor on
        new_objfile event chain.

Index: gdb/linux-thread-db.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-thread-db.c,v
retrieving revision 1.20
diff -u -p -r1.20 linux-thread-db.c
--- gdb/linux-thread-db.c	15 Oct 2006 19:38:45 -0000	1.20
+++ gdb/linux-thread-db.c	19 Oct 2006 20:08:44 -0000
@@ -599,6 +599,10 @@ check_for_thread_db (void)
   if (!target_has_execution)
     return;
 
+  /* Don't attempt to use thread_db for remote targets.  */
+  if (!target_can_run (&current_target))
+    return;
+
   /* Initialize the structure that identifies the child process.  */
   proc_handle.pid = GET_PID (inferior_ptid);
 
Index: gdb/remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.234
diff -u -p -r1.234 remote.c
--- gdb/remote.c	18 Oct 2006 16:56:13 -0000	1.234
+++ gdb/remote.c	19 Oct 2006 20:08:44 -0000
@@ -6126,8 +6126,7 @@ remote_new_objfile (struct objfile *objf
       remote_check_symbols (objfile);
     }
   /* Call predecessor on chain, if any.  */
-  if (remote_new_objfile_chain != 0 &&
-      remote_desc == 0)
+  if (remote_new_objfile_chain)
     remote_new_objfile_chain (objfile);
 }
 


-- 
  Dr. Ulrich Weigand
  Linux on zSeries Development
  Ulrich.Weigand@de.ibm.com