Re: [RFC] Replace deprecated_target_new_objfile_hook by observer?

[Daniel Jacobowitz <drow@false.org>]

On Tue, Oct 17, 2006 at 07:32:17PM -0400, Joel Brobecker wrote:
> I propose to replace this with an observer. Would that be OK?

There Be Dragons!  Note that there is a case where the remote objfile
hook does _not_ call the next thing on the chain.  This is somewhat
deliberate, in that it's what prevents thread-db from being enabled
when talking to gdbserver, and somewhat accidental, in that I'm sure it
wasn't meant to work this way.  But we'll need to do some rearranging
in order to keep the current state of affairs working.

> Assuming that it is, there are several platforms that use that
> mechanism. It's going to be hard to test all of them. But the changes
> themselves should be pretty mechanical. So what I can propose is
> to make all the necessary changes to replace that hook model with
> an approach using observers and test on x86-linux. And then rely
> on the mechanical aspect of the change together with the review of
> another pair of eyes. Would that be OK?

Isn't there already an adequate observer?  Well, not a single one I
guess, you'd have to survey the uses and see what they really wanted.
But solib_loaded goes a long way.

-- 
Daniel Jacobowitz
CodeSourcery