Re: PING Re: [RFC] thread tests, linux/gdbserver

[Daniel Jacobowitz <drow@false.org>]

On Fri, Oct 06, 2006 at 11:31:16AM -0700, Michael Snyder wrote:
> On Fri, 2006-10-06 at 12:53 +0200, Mark Kettenis wrote:
> > >  Any objections to this patch?
> > 
> > Hmm, I must have missed the origional mail, but I think we should actually
> > fix our code to print these things in a more consistent manner.
> 
> It comes from target_pid_to_str, which is a target method.
> We don't officially control what it looks like, since a target
> is free to say anything it likes.
> 
> Of course, we do control the remote target, which is all I'm
> immediately concerned with here.  It would be a one-line 
> change, I think, to capitalize it...

In fact, I was working on gdbserver support for tls.exp this morning,
and that's one of the affected tests.  So I made this change,
tested it with x86-64 gdbserver, and committed it.

It fixes a bunch of failures in linux-dp.exp and thread-specific.exp,
and lets more tests run for pthreads.exp.

-- 
Daniel Jacobowitz
CodeSourcery

2006-10-17  Daniel Jacobowitz  <dan@codesourcery.com>

	* remote.c (remote_pid_to_str): Capitalize "Thread".

Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.232
diff -u -p -r1.232 remote.c
--- remote.c	16 Oct 2006 03:08:37 -0000	1.232
+++ remote.c	17 Oct 2006 14:34:35 -0000
@@ -5834,7 +5834,7 @@ remote_pid_to_str (ptid_t ptid)
 {
   static char buf[32];
 
-  xsnprintf (buf, sizeof buf, "thread %d", ptid_get_pid (ptid));
+  xsnprintf (buf, sizeof buf, "Thread %d", ptid_get_pid (ptid));
   return buf;
 }