From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17965 invoked by alias); 17 Oct 2006 15:46:28 -0000 Received: (qmail 17854 invoked by uid 22791); 17 Oct 2006 15:46:25 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 17 Oct 2006 15:46:14 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GZr8t-0000IB-7i; Tue, 17 Oct 2006 11:46:11 -0400 Date: Tue, 17 Oct 2006 15:46:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Mark Kettenis , GDB Patches ML Subject: Re: PING Re: [RFC] thread tests, linux/gdbserver Message-ID: <20061017154611.GA30823@nevyn.them.org> Mail-Followup-To: Michael Snyder , Mark Kettenis , GDB Patches ML References: <1159223190.24808.52.camel@localhost.localdomain> <1160084737.9761.89.camel@localhost.localdomain> <20713.192.87.1.22.1160132019.squirrel@webmail.xs4all.nl> <1160159477.9761.124.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1160159477.9761.124.camel@localhost.localdomain> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00181.txt.bz2 On Fri, Oct 06, 2006 at 11:31:16AM -0700, Michael Snyder wrote: > On Fri, 2006-10-06 at 12:53 +0200, Mark Kettenis wrote: > > > Any objections to this patch? > > > > Hmm, I must have missed the origional mail, but I think we should actually > > fix our code to print these things in a more consistent manner. > > It comes from target_pid_to_str, which is a target method. > We don't officially control what it looks like, since a target > is free to say anything it likes. > > Of course, we do control the remote target, which is all I'm > immediately concerned with here. It would be a one-line > change, I think, to capitalize it... In fact, I was working on gdbserver support for tls.exp this morning, and that's one of the affected tests. So I made this change, tested it with x86-64 gdbserver, and committed it. It fixes a bunch of failures in linux-dp.exp and thread-specific.exp, and lets more tests run for pthreads.exp. -- Daniel Jacobowitz CodeSourcery 2006-10-17 Daniel Jacobowitz * remote.c (remote_pid_to_str): Capitalize "Thread". Index: remote.c =================================================================== RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.232 diff -u -p -r1.232 remote.c --- remote.c 16 Oct 2006 03:08:37 -0000 1.232 +++ remote.c 17 Oct 2006 14:34:35 -0000 @@ -5834,7 +5834,7 @@ remote_pid_to_str (ptid_t ptid) { static char buf[32]; - xsnprintf (buf, sizeof buf, "thread %d", ptid_get_pid (ptid)); + xsnprintf (buf, sizeof buf, "Thread %d", ptid_get_pid (ptid)); return buf; }