Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/dwarf2] Fix PR/2018 - set array type names
Date: Fri, 06 Oct 2006 19:28:00 -0000	[thread overview]
Message-ID: <20061006192758.GA15058@nevyn.them.org> (raw)
In-Reply-To: <20061006192303.GA1095@adacore.com>

On Fri, Oct 06, 2006 at 12:23:03PM -0700, Joel Brobecker wrote:
>         http://www.sourceware.org/ml/gdb-patches/2005-10/msg00086.html

I don't think I looked at this the first time you sent it.  The hack is
disgusting, but that's a problem for another day.  I think the comment
in GCC is simply incorrect for DWARF-2, and the array should have the
correct range type.

> 2006-10-06 Joel Brobecker  <brobecker@adacore.com>
> 
>         * dwarf2read.c (read_array_type): Set the type name if the name
>         attribute is present.
> 
> Tested on x86-linux, fixes the 4 KFAILs of gdb.ada/arrayidx.exp, no
> regression.  OK to commit?

OK.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-10-06 19:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-06 19:23 Joel Brobecker
2006-10-06 19:28 ` Daniel Jacobowitz [this message]
2006-10-06 20:39   ` Joel Brobecker
2006-10-06 20:49     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061006192758.GA15058@nevyn.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox