From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23965 invoked by alias); 6 Oct 2006 19:28:06 -0000 Received: (qmail 23955 invoked by uid 22791); 6 Oct 2006 19:28:06 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 06 Oct 2006 19:28:01 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GVvMU-0003w6-Pb; Fri, 06 Oct 2006 15:27:58 -0400 Date: Fri, 06 Oct 2006 19:28:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf2] Fix PR/2018 - set array type names Message-ID: <20061006192758.GA15058@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20061006192303.GA1095@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061006192303.GA1095@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00065.txt.bz2 On Fri, Oct 06, 2006 at 12:23:03PM -0700, Joel Brobecker wrote: > http://www.sourceware.org/ml/gdb-patches/2005-10/msg00086.html I don't think I looked at this the first time you sent it. The hack is disgusting, but that's a problem for another day. I think the comment in GCC is simply incorrect for DWARF-2, and the array should have the correct range type. > 2006-10-06 Joel Brobecker > > * dwarf2read.c (read_array_type): Set the type name if the name > attribute is present. > > Tested on x86-linux, fixes the 4 KFAILs of gdb.ada/arrayidx.exp, no > regression. OK to commit? OK. -- Daniel Jacobowitz CodeSourcery