Robustify mi-basics.exp

Robustify mi-basics.exp

[Vladimir Prus]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]


Hi,
at the moment, mi-basics.exp will fail if current directory contains any 
regexp metacharacters. Fixed with attached, OK?

- Volodya

2006-10-02  Vladimir Prus  <vladimir@codesourcery.com>

	* gdb.mi/mi-basics.exp (test_path_specification): Pass orig_path
        via string_to_regexp.
	* gdb.mi/mi2-basics.exp: Likewise.


[-- Attachment #2: funny_paths.diff --]
[-- Type: text/x-diff, Size: 1054 bytes --]

Index: mi-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-basics.exp,v
retrieving revision 1.14
diff -u -r1.14 mi-basics.exp
--- mi-basics.exp	10 Aug 2006 05:27:21 -0000	1.14
+++ mi-basics.exp	2 Oct 2006 15:47:24 -0000
@@ -219,6 +219,8 @@
 	}
     }
 
+    set orig_path [string_to_regexp ${orig_path}]
+
     mi_gdb_test "207-environment-path" \
              "207\\\^done,path=\"$orig_path\"" \
              "environment-path no-args operation"
Index: mi2-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-basics.exp,v
retrieving revision 1.6
diff -u -r1.6 mi2-basics.exp
--- mi2-basics.exp	10 Aug 2006 05:27:21 -0000	1.6
+++ mi2-basics.exp	2 Oct 2006 15:47:24 -0000
@@ -222,6 +222,8 @@
 	}
     }
 
+    set orig_path [string_to_regexp ${orig_path}]
+
     mi_gdb_test "207-environment-path" \
              "207\\\^done,path=\"$orig_path\"" \
              "environment-path no-args operation"

Re: Robustify mi-basics.exp

[Daniel Jacobowitz]

On Mon, Oct 02, 2006 at 07:52:13PM +0400, Vladimir Prus wrote:
> 
> Hi,
> at the moment, mi-basics.exp will fail if current directory contains any 
> regexp metacharacters. Fixed with attached, OK?

[The one that always bites us at CodeSourcery is "+", since there's a
"++" in most of our product names, and that's a regexp syntax error...]

> 2006-10-02  Vladimir Prus  <vladimir@codesourcery.com>
> 
> 	* gdb.mi/mi-basics.exp (test_path_specification): Pass orig_path
>         via string_to_regexp.
> 	* gdb.mi/mi2-basics.exp: Likewise.

OK, thanks!

-- 
Daniel Jacobowitz
CodeSourcery