From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: fnf@specifix.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: Include "defs.h" before other includes, for vec.c
Date: Fri, 29 Sep 2006 21:30:00 -0000 [thread overview]
Message-ID: <200609292130.k8TLULvg002314@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <200609291331.42865.fnf@specifix.com> (message from Fred Fish on Fri, 29 Sep 2006 13:31:42 -0700)
> From: Fred Fish <fnf@specifix.com>
> Date: Fri, 29 Sep 2006 13:31:42 -0700
>
> This fixes a problem on solaris, where vec.h causes types.h to be pulled in,
> but since _SYSCALL32 hasn't been defined yet (by config.h), off32_t doesn't
> get defined. Then later, defs.h pulls in config.h, which defines _SYSCALL32,
> and also causes fcntl.h to be pulled in, which sees _SYSCALL32 and tries
> to use off32_t, which isn't defined.
Heh, I just ran into this today. please commit if you didn't do so
already.
> 2006-09-29 Fred Fish <fnf@specifix.com>
>
> * vec.c: Include defs.h first. This pulls in config.h which can
> affect other includes.
prev parent reply other threads:[~2006-09-29 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 20:32 Fred Fish
2006-09-29 20:57 ` Daniel Jacobowitz
2006-09-29 21:30 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609292130.k8TLULvg002314@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=fnf@specifix.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox